On 2014/09/03 08:34:50, Weiliang wrote:
On 2014/09/03 02:29:48, Weiliang wrote:
>
https://codereview.chromium.org/424973004/diff/120001/src/profile-generator.h
> File src/profile-generator.h (right):
>
>
https://codereview.chromium.org/424973004/diff/120001/src/profile-generator.h#newcode58
> src/profile-generator.h:58:
pc_offset_map_.insert(std::make_pair(pc_offset,
> line));
> On 2014/09/01 10:44:38, Denis Pravdin wrote:
> > SetPosition is called during code generation. GetSourceLineNumber is
called
> > after the code is generated and line info table is built. Could you
please
> > clarify what kind of optimization are your talking about?
> >
> > On 2014/08/15 12:10:47, alph wrote:
> > > a possible optimization: you don't need to bloat it with a new
entry if
> > > lower_bound for the pc_offset does already return line.
> >
>
> Does it mean below?
> if (GetSourceLineNumber(pc_offset) ==
> v8::CpuProfileNode::kNoLineNumberInfo) {
> pc_offset_map_.insert(std::make_pair(pc_offset, line));
> }
Hi alph, danno and other reviewers
Could you please have a look?
The patch set 8 addressed the various codes issue. The previous failure is
because the function is already marked to be optimized but before the OSR
attempt, the func->code() is set to be the builtin of kCompileOptimized*,
which
is not the code object we want to test. The latest one adds some logic to
get
the correct code based on current function's optimization status.
BTW, it seems that test/cctest/test-cpu-profiler is disable by the
r23130(https://codereview.chromium.org/473873002). We enable it for our
local
test. Thanks again for your review.
Thanks
-Weiliang
Kindly ping. Hope it will not be rotted. :)
Thanks
-Weiliang
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
