LGTM
http://codereview.chromium.org/195015/diff/6001/6006 File src/debug.cc (right): http://codereview.chromium.org/195015/diff/6001/6006#newcode79 Line 79: // this stub to detect debugger calls generated from debugger; statements. Please remove the ; http://codereview.chromium.org/195015/diff/6001/6006#newcode364 Line 364: #ifdef DEBUG Please add a comment to why this #ifdef is intended. http://codereview.chromium.org/195015/diff/6001/6006#newcode1208 Line 1208: // Find out number of arguments from the stub minor key. Please make a comment about the argc in the stub is the number of arguments passed - not the expected arguments of the called function. http://codereview.chromium.org/195015/diff/6001/6004 File test/mjsunit/debug-stepin-call-function-stub.js (right): http://codereview.chromium.org/195015/diff/6001/6004#newcode85 Line 85: for (var i = 0; i < 2; i++) { Please change this to 3 as IC's does not kick in until after the second call. http://codereview.chromium.org/195015/diff/6001/6004#newcode101 Line 101: for (var i = 0; i < 2; i++) { Ditto. http://codereview.chromium.org/195015 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
