Reviewers: Jakob,

Message:
ping?

Description:
Nuke support for running MSan without a simulator.

We've abandoned that approach. The ARM64 simulator is the only supported way of
running V8 under MSan.

BUG=none
[email protected]

Please review this at https://codereview.chromium.org/493923003/

SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge

Affected files (+0, -8 lines):
  M src/heap/spaces.cc
  M src/msan.h


Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index ff55c89e5d2f34036d79a8d57e704bf9c2dd9302..a294acf40b22db82849aabb7b3716169383dd867 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -661,7 +661,6 @@ MemoryChunk* MemoryAllocator::AllocateChunk(intptr_t reserve_area_size,
   MemoryChunk* result = MemoryChunk::Initialize(
       heap, base, chunk_size, area_start, area_end, executable, owner);
   result->set_reserved_memory(&reservation);
-  MSAN_MEMORY_IS_INITIALIZED_IN_JIT(base, chunk_size);
   return result;
 }

Index: src/msan.h
diff --git a/src/msan.h b/src/msan.h
index dfcbd239e14aa1dd7c0bd08f4fe04ed6450f2fd4..c9be8643aebd81bcf375a98d2856b57d6bb58675 100644
--- a/src/msan.h
+++ b/src/msan.h
@@ -27,11 +27,4 @@
 # define MSAN_ALLOCATED_UNINITIALIZED_MEMORY(p, s)
 #endif

-#if defined(MEMORY_SANITIZER) && !defined(USE_SIMULATOR)
-// Marks a memory range as fully initialized.
-# define MSAN_MEMORY_IS_INITIALIZED_IN_JIT(p, s) __msan_unpoison((p), (s))
-#else
-# define MSAN_MEMORY_IS_INITIALIZED_IN_JIT(p, s)
-#endif
-
 #endif  // V8_MSAN_H_


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to