On 2014/09/17 10:04:11, yurys wrote:
I will take care of landing the cl.
On 2014/09/17 03:14:12, Weiliang wrote:
> On 2014/09/16 10:10:39, yurys wrote:
> > lgtm
>
> Hi Yurys
>
> Please see again the patch set 15.
>
> I have rebased it and fixed the failure I talked with you when turbo
fan is
> turned on. The root cause of the failure is turbo fan enables
--turbo_types
flag
> by default recently and is able to emit better JIT code with less IC
CALL(For
> example, no IC call now is emitted by TF for the example
function("func") of
> TickLines test). And turbo fan only emits source position info if
> FLAG_turbo_source_positions is on or the node is a Call. That is why
there
is
no
> line info after rebasing for turbo fan.
>
Is it going to be enabled by default or will we miss source line positions
with
turbo fan?
Thanks.
I am not sure whether it (FLAG_turbo_source_positions) will be enabled by
default. @danno, @titzer may know.
Thanks
-Weiliang
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
