STV!
http://codereview.chromium.org/199075/diff/4006/4015 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/199075/diff/4006/4015#newcode329 Line 329: __ add(sp, sp, Operand((scope_->num_parameters() + 1) * kPointerSize)); The generated code coverage test relies on you using masm_-> instead of __ in the places where you don't want the code instrumented because you are relying on its size. Probably the generated code coverage stuff doesn't work right now, but if it is to be made to work again then this is the sort of place where we will need to write masm_-> http://codereview.chromium.org/199075/diff/4006/4017 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/199075/diff/4006/4017#newcode1155 Line 1155: #ifdef ENABLE_DEBUGGER_SUPPORT I hope you checked that it still compiles with and without this. http://codereview.chromium.org/199075/diff/4006/4011 File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/199075/diff/4006/4011#newcode345 Line 345: // the exact number of bytes specified must be emitted. Is not legal to emit Is -> It is http://codereview.chromium.org/199075/diff/4006/4011#newcode347 Line 347: // an assertion. assertion -> assertion to fail http://codereview.chromium.org/199075 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
