[v8-dev] Re: Implement data property creation for assignments to super.x. (issue 618643003 by dslomov@chromium.org)

[dslomov]

On 2014/09/30 13:52:17, arv wrote:
https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):


https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode126
test/mjsunit/harmony/super.js:126: x : "x from Base"
stick to '


https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode126
test/mjsunit/harmony/super.js:126: x : "x from Base"
no ws before :


https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode210
test/mjsunit/harmony/super.js:210: super.newProperty = 15;
I'm having a hard time seeing why this should throw?

https://people.mozilla.org/~jorendorff/es6-draft.html#sec-putvalue

Is it throwing because we eventually get to a 42[[DefineOwnProperty]]  
which
returns false?


https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode211
test/mjsunit/harmony/super.js:211: } catch(e) { ex = e; }
ws between catch and (
Thanks a lot, style nits fixed in https://codereview.chromium.org/613253002

https://codereview.chromium.org/618643003/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.