Addressed Ross' comments.
https://codereview.chromium.org/609843002/diff/40001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/609843002/diff/40001/src/arm64/macro-assembler-arm64.cc#newcode3069
src/arm64/macro-assembler-arm64.cc:3069: // Constant pool not
implemented on arm64.
On 2014/10/09 09:22:48, rmcilroy wrote:
Out-of-line constant pool not... (arm64 does have an inline constant
pool).
Please change for other architectures as well.
Done.
https://codereview.chromium.org/609843002/diff/40001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/609843002/diff/40001/src/assembler.cc#newcode135
src/assembler.cc:135:
ool_constant_pool_available_(!FLAG_enable_ool_constant_pool) {
On 2014/10/09 09:22:48, rmcilroy wrote:
nit - just make this false (we were previously setting it to true if
!FLAG_enable_ool_constant_pool on Arm since we were using it to check
for inline
constant pool too).
Done.
https://codereview.chromium.org/609843002/diff/40001/src/assembler.h
File src/assembler.h (right):
https://codereview.chromium.org/609843002/diff/40001/src/assembler.h#newcode135
src/assembler.h:135: // constant pool
On 2014/10/09 09:22:48, rmcilroy wrote:
/s/constant pool/Constant pool.
Done.
https://codereview.chromium.org/609843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
