https://codereview.chromium.org/639123009/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/639123009/diff/1/src/ia32/full-codegen-ia32.cc#newcode2446
src/ia32/full-codegen-ia32.cc:2446: __
CallRuntime(Runtime::kSetProperty, 4);
On 2014/10/18 09:04:59, Dmitry Lomov (chromium) wrote:
On 2014/10/18 08:30:33, Dmitry Lomov (chromium) wrote:
> You should use StoreIC here (see EmitKeyedPropertyAssignment for how
it is
done)

s/Keyed/Named/ of course.
Maybe given how much runtime calling is going on here anyway, maybe
it's not
worth it yet to install ICs here

I'm not sure that is correct? We are not doing assignment here but
define.

https://codereview.chromium.org/639123009/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to