Landed in bleeding_edge revision 2965. Pushing to trunk now. On Wed, Sep 23, 2009 at 4:31 PM, Mads Sig Ager <[email protected]> wrote: > I'll pull it in and push it to trunk. > > On Wed, Sep 23, 2009 at 4:27 PM, <[email protected]> wrote: >> >> Reviewers: Mark Mentovai, >> >> Message: >> Mark: can you comment on whether I'm interpreting the latest gyp behavior >> correctly please? >> >> V8 people: this is currently stopping people with gcc 4.4 who need to use >> gcc_version=44 from compiling chromium. I assume this will have to be merged >> onto whatever branch is used for chromium and someone would have to roll >> DEPS >> etc. too? >> >> Thank you. >> >> Description: >> Remove quotes around "44" when checking gcc_version in v8.gyp. >> >> This is necessary due to a recent change in gyp that turns a >> numeric string value in a gyp variable into an integer. >> >> Please review this at http://codereview.chromium.org/230001 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M tools/gyp/v8.gyp >> >> >> Index: tools/gyp/v8.gyp >> =================================================================== >> --- tools/gyp/v8.gyp (revision 2963) >> +++ tools/gyp/v8.gyp (working copy) >> @@ -87,7 +87,7 @@ >> '-O3', >> ], >> 'conditions': [ >> - [ 'gcc_version=="44"', { >> + [ 'gcc_version==44', { >> 'cflags': [ >> # Avoid gcc 4.4 strict aliasing issues in dtoa.c >> '-fno-strict-aliasing', >> >> >> >> >> >> >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
