That part of it looks good to me.
http://codereview.chromium.org/200095/diff/10001/10012 File src/serialize.cc (right): http://codereview.chromium.org/200095/diff/10001/10012#newcode940 Line 940: Code* target = Code::GetCodeFromTargetAddress(rinfo->target_address()); This is ugly, but lets just put it in anyway because I plan to remove all this code real soon now. http://codereview.chromium.org/200095/diff/10001/10012#newcode943 Line 943: intptr_t int_target = reinterpret_cast<intptr_t>(encoded_target); Please assert this fits in low 32 bits. http://codereview.chromium.org/200095/diff/10001/10012#newcode944 Line 944: int_target = (int_target & 0xFFFFFFFFU) | (Memory::uint64_at(rinfo->pc() + 4) << 32); This won't lint! And looks like it doesn't work in 32 bit. http://codereview.chromium.org/200095 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
