Nice, it's always nice when a 2 year old CL comes back :). LGTM, but please
wait for Ulan since I don't know the code you are touching in heap-inl.h
very
well.
https://codereview.chromium.org/677043002/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/677043002/diff/1/src/heap/mark-compact.cc#newcode1356
src/heap/mark-compact.cc:1356:
Smi::FromInt(JSRegExp::kUninitializedValue));
Could you split this out so that it's shared with the code in lines
1384-1387.
https://codereview.chromium.org/677043002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/677043002/diff/1/test/cctest/test-api.cc#newcode18738
test/cctest/test-api.cc:18738:
CcTest::heap()->CollectAllAvailableGarbage("Swift blow to evil", 1);
:)
https://codereview.chromium.org/677043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
