lgtm %
https://codereview.chromium.org/677953004/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/677953004/diff/1/src/preparser.h#newcode1973
src/preparser.h:1973: if (*has_seen_constructor) {
It's not trivial to see that has_seen_constructor cannot be NULL here...
so the caller must always pass non-NULL if in_class and !is_static, but
otherwise it's ok to pass NULL? This is quite subtle. CHECK that this is
followed? Document it better? Or make this if (has_seen_constructor &&
*has_seen_constructor)? Always pass a dummy non-NULL ptr? Idk what would
be the best solution. Wdyt?
https://codereview.chromium.org/677953004/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/677953004/diff/1/test/cctest/test-parsing.cc#newcode4042
test/cctest/test-parsing.cc:4042: // We currently do not allow any
duplicate properties in class bodies. This
This comment seems out of date now.
https://codereview.chromium.org/677953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
