Thanks for the review, addressed comments, PTALA.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/677433002/diff/250001/src/compiler/arm/instruction-selector-arm.cc#newcode842
src/compiler/arm/instruction-selector-arm.cc:842: if
(!CpuFeatures::IsSupported(ARMv8)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/arm/instruction-selector-arm.cc#newcode850
src/compiler/arm/instruction-selector-arm.cc:850: if
(!CpuFeatures::IsSupported(ARMv8)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/arm/instruction-selector-arm.cc#newcode858
src/compiler/arm/instruction-selector-arm.cc:858: if
(!CpuFeatures::IsSupported(ARMv8)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/arm/instruction-selector-arm.cc#newcode866
src/compiler/arm/instruction-selector-arm.cc:866: if
(!CpuFeatures::IsSupported(ARMv8)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/ia32/instruction-selector-ia32.cc
File src/compiler/ia32/instruction-selector-ia32.cc (right):
https://codereview.chromium.org/677433002/diff/250001/src/compiler/ia32/instruction-selector-ia32.cc#newcode608
src/compiler/ia32/instruction-selector-ia32.cc:608: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/ia32/instruction-selector-ia32.cc#newcode616
src/compiler/ia32/instruction-selector-ia32.cc:616: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/ia32/instruction-selector-ia32.cc#newcode624
src/compiler/ia32/instruction-selector-ia32.cc:624: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:12, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/instruction-selector.h
File src/compiler/instruction-selector.h (right):
https://codereview.chromium.org/677433002/diff/250001/src/compiler/instruction-selector.h#newcode16
src/compiler/instruction-selector.h:16: #define
UNSUPPORTED_OPERATOR(node) \
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
Please remove this macro and use UNREACHABLE() in Visit<OP>() methods
or DCHECK
for the required features.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/677433002/diff/250001/src/compiler/x64/instruction-selector-x64.cc#newcode735
src/compiler/x64/instruction-selector-x64.cc:735: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/x64/instruction-selector-x64.cc#newcode743
src/compiler/x64/instruction-selector-x64.cc:743: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/x64/instruction-selector-x64.cc#newcode751
src/compiler/x64/instruction-selector-x64.cc:751: if
(!CpuFeatures::IsSupported(SSE4_1)) {
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
I think this should be DCHECK(CpuFeatures::IsSupported(ARMv8))
instead.
Done.
https://codereview.chromium.org/677433002/diff/250001/src/compiler/x64/instruction-selector-x64.cc#newcode759
src/compiler/x64/instruction-selector-x64.cc:759:
UNSUPPORTED_OPERATOR(node);
On 2014/10/30 11:59:13, Benedikt Meurer wrote:
Just put in UNREACHABLE(); here.
Done.
https://codereview.chromium.org/677433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
