Feedback addressed, landing
https://codereview.chromium.org/704713003/diff/220001/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/704713003/diff/220001/src/compiler/x64/instruction-selector-x64.cc#newcode370
src/compiler/x64/instruction-selector-x64.cc:370: int scale_factor,
Node* offset,
On 2014/11/07 16:17:38, titzer wrote:
Let's call it scale_exponent to avoid confusion.
Done.
https://codereview.chromium.org/704713003/diff/220001/src/compiler/x64/instruction-selector-x64.cc#newcode382
src/compiler/x64/instruction-selector-x64.cc:382: static const
AddressingMode kMRnI_modes[] = {kMode_MR1I, kMode_MR2I,
On 2014/11/07 09:11:43, dcarney wrote:
for all these you can just use
AdjustAddressingMode(kMode_MR1I, scale)
like in instruction-selector-ia32
That would mean copying the code here, and the implicit Mode -> int
conversion seems a bit dangerous, I actually prefer the explicit list.
https://codereview.chromium.org/704713003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
