Toon is clearly the expert here, but I'm learning by reading this patch.
Just
one nit.
https://codereview.chromium.org/696783005/diff/20001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/696783005/diff/20001/src/hydrogen-instructions.cc#newcode4647
src/hydrogen-instructions.cc:4647: int offset =
GlobalContextTable::kHeaderSize + (index + 1) * kPointerSize;
Here's that "+ 1" again. Now that it's leaking out of the
GlobalContextTable implementation, perhaps it's worth adding a constant?
https://codereview.chromium.org/696783005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
