Turns out that the code I was going to beg forgiveness for can simply be
deleted.
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode984
src/ppc/code-stubs-ppc.cc:984: //
WriteInt32ToHeapNumberStub::GenerateFixedRegStubsAheadOfTime(isolate);
On 2014/11/07 18:03:17, andrew_low wrote:
On 2014/10/20 08:28:43, danno wrote:
> Really delete this line?
When we were doing this work originally including this line caused a
crash on
startup.
At this point - by running without this line, it caused this code
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode984
to not be needed.
I'd like to simply beg forgiveness for this missing part of the
implementation
to help us get past this code contribution. We'll take another run at
including
it in the near future.
Hah. One of the guys here looked at it, and it appears that this is
'dead' code even on ARM. So it should be removed from PPC and ARM (along
with the associated code).
https://codereview.chromium.org/571173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
