Reviewers: jochen (slow), Benedikt Meurer, Michael Starzinger, Sven Panne,
Message:
On 2014/11/12 15:03:16, jochen (slow) wrote:
lgtm
Something strange with trybot results...
Description:
Fix include mistakes
1) Missing <stdio.h> while using fopen, fclose, fseek etc
2) platform-linux.cc includes <sys/types.h> wtice
BUG=v8:3691
Please review this at https://codereview.chromium.org/716123003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/base/platform/platform-linux.cc
M src/base/platform/platform-posix.cc
Index: src/base/platform/platform-linux.cc
diff --git a/src/base/platform/platform-linux.cc
b/src/base/platform/platform-linux.cc
index
b13a1e85c540eadf54a23735482c67c8b3bd9c0a..36857e62194df5a1329bf853613dba0386c1817a
100644
--- a/src/base/platform/platform-linux.cc
+++ b/src/base/platform/platform-linux.cc
@@ -8,10 +8,10 @@
#include <pthread.h>
#include <semaphore.h>
#include <signal.h>
+#include <stdio.h>
#include <stdlib.h>
#include <sys/resource.h>
#include <sys/time.h>
-#include <sys/types.h>
// Ubuntu Dapper requires memory pages to be marked as
// executable. Otherwise, OS raises an exception when executing code
Index: src/base/platform/platform-posix.cc
diff --git a/src/base/platform/platform-posix.cc
b/src/base/platform/platform-posix.cc
index
0a222a612e7fd7959b364fd5f47ec8e8b2ac5461..0b16dfdcc6bae14c943f2253e40674c2edb667d0
100644
--- a/src/base/platform/platform-posix.cc
+++ b/src/base/platform/platform-posix.cc
@@ -13,6 +13,7 @@
#include <pthread_np.h> // for pthread_set_name_np
#endif
#include <sched.h> // for sched_yield
+#include <stdio.h>
#include <time.h>
#include <unistd.h>
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
