Your CL should fix the problem. However, the question is should we do
something
more general like e.g. soft references which just get cleared on memory
pressure? Do you think soft references would be less performant? I am just
worried that we introduce another special weak handling mechanism instead of
doing a general, reusable solution.
https://codereview.chromium.org/688853007/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/688853007/diff/1/src/heap/heap.cc#newcode1247
src/heap/heap.cc:1247: }
Factor that code out into a function to keep the prologue simple, e.g.
AgeEmbeddedMapCache.
https://codereview.chromium.org/688853007/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/688853007/diff/1/src/heap/mark-compact.cc#newcode2204
src/heap/mark-compact.cc:2204: ProcessMarkingDeque();
Why?
https://codereview.chromium.org/688853007/diff/1/src/heap/mark-compact.cc#newcode3541
src/heap/mark-compact.cc:3541: // No need to iterate the contents of the
embedded map cache since
Please move the comment before
updating_visitor.VisitPointer(heap_->embedded_map_cache_address()); and
say something like "We just visit the embedded_map_cache slot here and
update it if needed. No need to iterate the contents of the embedded
map cache since maps do not move."
https://codereview.chromium.org/688853007/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/688853007/diff/1/src/objects-inl.h#newcode3314
src/objects-inl.h:3314: CAST_ACCESSOR(EmbeddedMapCache)
alphabetic order
https://codereview.chromium.org/688853007/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/688853007/diff/1/src/objects.h#newcode4000
src/objects.h:4000: class HeapPointerShape : public
BaseShape<Handle<Object> > {
Why is that a good name?
https://codereview.chromium.org/688853007/diff/1/src/objects.h#newcode4052
src/objects.h:4052:
Please add a detailed description about what the EmbeddedMapCache is and
what it motivation is.
https://codereview.chromium.org/688853007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
