https://codereview.chromium.org/750813003/diff/130001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/750813003/diff/130001/include/v8.h#newcode5001
include/v8.h:5001: * done within the time limit.
On 2014/11/25 14:28:06, rmcilroy wrote:
nit - mention that deadline_seconds is compared with
MonotonicallyIncreasingTime() and should be based on the same timebase
as that
function.
Done.
https://codereview.chromium.org/750813003/diff/130001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/750813003/diff/130001/src/api.cc#newcode6637
src/api.cc:6637: return
isolate->heap()->IdleNotification(deadline_in_seconds);
On 2014/11/25 14:28:06, rmcilroy wrote:
you need to multiply by 1000 right? Could we just convert to
base::TimeTicks
internally to avoid the confusion?
I moved the conversion to the actual IdleNotification implementation.
https://codereview.chromium.org/750813003/diff/130001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/750813003/diff/130001/src/heap/gc-idle-time-handler.cc#newcode169
src/heap/gc-idle-time-handler.cc:169: GCIdleTimeAction
GCIdleTimeHandler::Compute(double idle_time,
On 2014/11/25 14:28:06, rmcilroy wrote:
nit - keep this as idle_time_in_ms
Done.
https://codereview.chromium.org/750813003/diff/130001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/750813003/diff/130001/src/heap/heap.cc#newcode4398
src/heap/heap.cc:4398: static_cast<double>(idle_time_in_ms));
On 2014/11/25 14:28:06, rmcilroy wrote:
indentation.
gc format is formatting it like that.
https://codereview.chromium.org/750813003/diff/130001/src/heap/heap.cc#newcode4430
src/heap/heap.cc:4430: deadline_in_ms -
V8::GetCurrentPlatform()->MonotonicallyIncreasingTime();
On 2014/11/25 14:28:06, rmcilroy wrote:
still subtracting seconds from ms here.
Done.
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
