lgtm
https://codereview.chromium.org/763273002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/763273002/diff/1/src/flag-definitions.h#newcode206
src/flag-definitions.h:206: DEFINE_IMPLICATION(harmony_shipping, id)
On 2014/11/28 13:34:41, Dmitry Lomov (chromium) wrote:
On 2014/11/28 12:28:36, rossberg wrote:
> Hm, don't you also need a NEG_IMPLICATION here to actually make
> --noharmony-shipping a kill switch?
No, why? NEG_IMPLICATION(flag1,flag2) means `if (flag1) flag2 = false`
so not
applicable here.
The way this works here is that features are off by default, and
harmony_shipping turns them on.
harmony_shipping is on by default, so features are on.
If harmony_shipping is turned off via command line, feature flags take
their
default value which is 'off'.
Ah, I see.
https://codereview.chromium.org/763273002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
