Reviewers: Sven Panne, Jakob, danno, Nico,
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118
include/v8config.h:118: #if defined(__clang__)
So you're talking about either setting both V8_CC_CLANG and V8_CC_GNU or
setting both V8_CC_CLANG and V8_CC_MSVC? That'll require some careful
changes to several files.
Description:
Move OS/compiler/feature detection to public v8config.h header.
From now on the v8config.h header should be the one and
only file where we do (freaky) checks to detect OS, C++
compiler or certain compiler features. Since we need that
both internally and for the public API, the new v8config.h
is the proper place to add (everything is prefixed with V8_
so we are safe).
R=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16281
Please review this at https://codereview.chromium.org/23248006/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+313, -162 lines):
M include/v8.h
A include/v8config.h
M include/v8stdint.h
M src/checks.h
M src/globals.h
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
