Comment #3 on issue 3663 by [email protected]: Clearing of ICs at GC degrades performance
https://code.google.com/p/v8/issues/detail?id=3663#c3
The following revision refers to this bug:https://chromium.googlesource.com/v8/v8.git/+/d9c83f6bd0c9bd6806146caaa8053f61a800543d
commit d9c83f6bd0c9bd6806146caaa8053f61a800543d Author: machenbach <[email protected]> Date: Tue Dec 02 08:16:43 2014Revert of Use weak cells in map checks in polymorphic ICs. (patchset #8 id:140001 of https://codereview.chromium.org/753993003/)
Reason for revert: [Sheriff] Speculative revert for breaking chromium asan (roll blocker): http://build.chromium.org/p/client.v8/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1683 Original issue's description:
Use weak cells in map checks in polymorphic ICs.
BUG=v8:3663 LOG=N
[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=v8:3663 Review URL: https://codereview.chromium.org/771033003 Cr-Commit-Position: refs/heads/master@{#25597}[modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/arm/macro-assembler-arm.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/arm/macro-assembler-arm.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/arm64/lithium-codegen-arm64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/arm64/macro-assembler-arm64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/arm64/macro-assembler-arm64.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/factory.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/heap/objects-visiting-inl.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ia32/macro-assembler-ia32.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ia32/macro-assembler-ia32.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/arm/ic-compiler-arm.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/arm64/ic-compiler-arm64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/ia32/ic-compiler-ia32.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/mips/ic-compiler-mips.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/mips64/ic-compiler-mips64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/x64/ic-compiler-x64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/ic/x87/ic-compiler-x87.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/mips/macro-assembler-mips.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/mips/macro-assembler-mips.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/mips64/macro-assembler-mips64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/mips64/macro-assembler-mips64.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/objects-inl.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/objects-printer.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/objects.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/objects.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/x64/macro-assembler-x64.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/x64/macro-assembler-x64.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/x87/macro-assembler-x87.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/src/x87/macro-assembler-x87.h [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/test/cctest/cctest.status [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/test/cctest/test-heap.cc [modify] http://crrev.com/d9c83f6bd0c9bd6806146caaa8053f61a800543d/test/mjsunit/opt-elements-kind.js
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
