https://codereview.chromium.org/753553002/diff/80001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/753553002/diff/80001/include/v8.h#newcode510
include/v8.h:510: V8_INLINE void Empty() { val_ = NULL; }
what do you need Empty() for?
https://codereview.chromium.org/753553002/diff/80001/include/v8.h#newcode565
include/v8.h:565: int internalFieldOffset1, int internalFieldOffset2);
internal_field_index1
https://codereview.chromium.org/753553002/diff/80001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/753553002/diff/80001/src/global-handles.cc#newcode43
src/global-handles.cc:43: INTERNAL_FIELDS_WEAK // Embedded gets 2
internal fields from dying object.
Embedder
https://codereview.chromium.org/753553002/diff/80001/src/global-handles.cc#newcode272
src/global-handles.cc:272: set_internal_fields(internal_field_index1,
internal_field_index2);
is there a check somewhere that the object actually has that many
internal fields?
https://codereview.chromium.org/753553002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/753553002/diff/80001/src/heap/mark-compact.cc#newcode2219
src/heap/mark-compact.cc:2219: ProcessMarkingDeque();
this is not needed, because the following call to
ProcessEphemeralMarking processes the deque anyways
https://codereview.chromium.org/753553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
