Addressed comments. PTAL.
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h
File src/compiler/control-equivalence.h (right):
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h#newcode28
src/compiler/control-equivalence.h:28: // down cycle equivalence for
strongly connected control flow graphs.
On 2014/12/01 20:56:24, jarin wrote:
Did not quite understand the last sentence, perhaps you could to say
"...
reduces to undirected cycle equivalence for..."?
Done.
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h#newcode30
src/compiler/control-equivalence.h:30: // The algorithm is based on
research by Johnson, Pearson & Pingali which also
On 2014/12/01 20:56:24, jarin wrote:
Could you give a more complete citation? (At least the name of the
article.)
Done.
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h#newcode43
src/compiler/control-equivalence.h:43: // 1) A breath-first backwards
traversal to determine the set of nodes that
On 2014/12/01 20:56:24, jarin wrote:
typo: breadth
Done.
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h#newcode127
src/compiler/control-equivalence.h:127: SetClass(node,
recent->recent_class);
On 2014/12/01 20:56:24, jarin wrote:
I am quite confused here when trying to match the algorithm to the one
described
in the paper. Could you make the connection more explicit?
Specifically, I do not see how you handle the capping backedge
business here.
(Since you do not do the capping backedges, it appears that you do not
even use
the DFS numbers.) Why do not we need it?
I am also missing the edge that is supposed to connect the input and
output
version of the node. Could you explain where/how is it encoded?
Acknowledged.
As discussed offline: The capping backedges are not added yet, I still
need to write test cases that proof that (and why) we need them. As for
traversal, I added a comment that try to explain the implementation. And
also I added references to the algorithm from the paper as hints. Let me
know if these comments improve the situation.
https://codereview.chromium.org/738613005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
