caitp:
Test that an exception during a getter results propagates the exception
Already there; search for "should terminate if getting an index throws an
exception"
arv:
added the tests and addressed the nits, I think!
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes-to-object.js
File test/mjsunit/harmony/array-includes-to-object.js (right):
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes-to-object.js#newcode12
test/mjsunit/harmony/array-includes-to-object.js:12: //
Array.prototype.includes should use ToObject on this, so that when
called with a number, it picks up numeric properties from
Number.prototype
On 2014/12/04 21:04:00, arv wrote:
Can you add a test that this inside a getter has the right type?
Done.
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes-to-object.js#newcode21
test/mjsunit/harmony/array-includes-to-object.js:21: })();
On 2014/12/04 20:53:02, caitp wrote:
Usually these tests include `assertThrows(function() {
Array.prototype.includes.call(undefined, whatever); }, TypeError);`
and similar
Done.
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js
File test/mjsunit/harmony/array-includes.js (right):
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js#newcode11
test/mjsunit/harmony/array-includes.js:11: //
On 2014/12/04 21:04:00, arv wrote:
Nit. We don't use this kind of formatting in other places. Since this
is
generated maybe do:
Hmm OK I was copying
https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/mjsunit/harmony/array-findindex.js
will fix
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js#newcode11
test/mjsunit/harmony/array-includes.js:11: //
On 2014/12/04 21:04:00, arv wrote:
Nit. We don't use this kind of formatting in other places. Since this
is
generated maybe do:
// Array.prototype.includes sees a new element added by a getter that
is hit
during iteration
(function() {
Done.
https://codereview.chromium.org/771863002/diff/60001/test/mjsunit/harmony/array-includes.js#newcode27
test/mjsunit/harmony/array-includes.js:27:
On 2014/12/04 21:04:01, arv wrote:
We use 2 newlines between the test "blocks"
Done.
https://codereview.chromium.org/771863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
