https://codereview.chromium.org/770333005/diff/20001/src/harmony-regexp.js
File src/harmony-regexp.js (right):
https://codereview.chromium.org/770333005/diff/20001/src/harmony-regexp.js#newcode15
src/harmony-regexp.js:15: var RegExpGetFlags = function() {
Move this out of ExtendRegExpPrototype.
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/regexp-flags.js
File test/mjsunit/harmony/regexp-flags.js (right):
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/regexp-flags.js#newcode7
test/mjsunit/harmony/regexp-flags.js:7: assertEquals('',
RegExp.prototype.flags);
Shouldn't this throw since the prototype object does not have
[[OriginalFlags]]?
I guess this is a really a bug in our implementation of
RegExp.prototype.global. But once/if we fix that then this test will
start to fail.
https://codereview.chromium.org/770333005/diff/20001/test/mjsunit/harmony/regexp-flags.js#newcode8
test/mjsunit/harmony/regexp-flags.js:8: RegExp.prototype.flags = 'foo';
A better test is to get the descriptor and validate it.
https://codereview.chromium.org/770333005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
