The test case came from me trying to produce a repro. At that time it wasn't clear why the file size mattered. On Dec 11, 2014 9:08 AM, <dslo...@chromium.org> wrote:
> On 2014/12/11 14:04:46, caitp wrote: > >> On 2014/12/11 14:01:17, marja wrote: >> > >> > > https://codereview.chromium.org/792083002/diff/40001/test/ > cctest/test-parsing.cc > >> > File test/cctest/test-parsing.cc (right): >> > >> > >> > > https://codereview.chromium.org/792083002/diff/40001/test/ > cctest/test-parsing.cc#newcode4490 > >> > test/cctest/test-parsing.cc:4490: "// >> > xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" >> > But but... RunParserSyncTest already tests preparsing against parsing. >> What >> > am > >> I >> > missing? >> > > hmmm --- well lets a fair question --- without the parser fixes, the test >> does >> fail even without the flag, so I guess it's not needed. >> > > In real life (tm) we make decision to preparse or not to preparse based on > code > size. > In the test we force preparsing no matter what. > > > https://codereview.chromium.org/792083002/ > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > ---You received this message because you are subscribed to the Google > Groups "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
