Reviewers: jochen (slow),
Message:
Jochen, PTAL, thanks.
Description:
[GN] Output external snapshot blobs in out directory.
The snapshot and natives blob files should be output in the out directory
instead of the gen directory so that they can be picked up by the
executable.
BUG=421063
LOG=N
Please review this at https://codereview.chromium.org/805813004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -3 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
d6b6ec22aefc5822dee01958cd214e66c40eb025..bfeac0b01f24c58a29045f99facb424dea223353
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -280,7 +280,7 @@ if (v8_use_external_startup_data) {
]
outputs = [
- "$root_gen_dir/natives_blob.bin"
+ "$root_out_dir/natives_blob.bin"
]
script = "tools/concatenate-files.py"
@@ -333,10 +333,10 @@ action("run_mksnapshot") {
}
if (v8_use_external_startup_data) {
- outputs += [ "$root_gen_dir/snapshot_blob.bin" ]
+ outputs += [ "$root_out_dir/snapshot_blob.bin" ]
args += [
"--startup_blob",
- rebase_path("$root_gen_dir/snapshot_blob.bin", root_build_dir)
+ rebase_path("$root_out_dir/snapshot_blob.bin", root_build_dir)
]
}
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
