https://codereview.chromium.org/812163003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/812163003/diff/1/src/preparser.h#newcode2849
src/preparser.h:2849: CheckOctalLiteral(pos, peek_position(), CHECK_OK);
On 2014/12/18 20:46:58, arv wrote:
On 2014/12/18 20:44:18, caitp wrote:
> On 2014/12/18 20:38:51, arv wrote:
> > CheckOctalLiteral needs to be updated to use a different error
message.
>
> Yeah --- I was undecided whether it should be something generic like
"Octal
> escape sequences are deprecated", or let callers pass in their own
message ID
> and make a template-specific error message.
>
> What do you think?

I think a new error message would be best.

Done and done

https://codereview.chromium.org/812163003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to