https://codereview.chromium.org/788043005/diff/220001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/788043005/diff/220001/src/parser.cc#newcode4354
src/parser.cc:4354: }
Should `-` be a “syntax character” as well because of its special
meaning within character classes (e.g. `/[a-b]/`)?
https://codereview.chromium.org/788043005/diff/220001/src/regexp.js
File src/regexp.js (right):
https://codereview.chromium.org/788043005/diff/220001/src/regexp.js#newcode28
src/regexp.js:28: flags += (pattern.unicode ? 'u' : '');
`u` goes before `y`.
https://codereview.chromium.org/788043005/diff/220001/src/regexp.js#newcode241
src/regexp.js:241: if (harmony_unicode && this.unicode) result += 'u';
Same here.
https://codereview.chromium.org/788043005/diff/220001/test/mjsunit/harmony/unicode-escapes-in-regexps.js
File test/mjsunit/harmony/unicode-escapes-in-regexps.js (right):
https://codereview.chromium.org/788043005/diff/220001/test/mjsunit/harmony/unicode-escapes-in-regexps.js#newcode212
test/mjsunit/harmony/unicode-escapes-in-regexps.js:212: })();
How about adding a test for `/[a-c\-]/u`, given the above comment?
Also you may want to update `test/mjsunit/harmony/regexp-flags.js` so it
includes `u`.
https://codereview.chromium.org/788043005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
