Reviewers: Hannes Payer,
Message:
PTAL
https://codereview.chromium.org/866723002/diff/1/src/lithium.cc
File src/lithium.cc (right):
https://codereview.chromium.org/866723002/diff/1/src/lithium.cc#newcode416
src/lithium.cc:416: static void AddWeakObjectToCodeDependency(Isolate*
isolate,
Move these functions from src/lithium-codegen.cc.
https://codereview.chromium.org/866723002/diff/1/src/lithium.cc#newcode467
src/lithium.cc:467: code->set_can_have_weak_objects(true);
The line above is the only change. After this point all
weak-dependencies are registered, so GC can start treating the pointers
as weak.
Description:
Treat pointers in optimized code as strong before all weak dependencies are
registered.
This prevents GC from observing code objects with out-of-sync weak
dependencies.
BUG=v8:3823
LOG=N
Please review this at https://codereview.chromium.org/866723002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+85, -97 lines):
M src/arm/lithium-codegen-arm.cc
M src/arm64/lithium-codegen-arm64.cc
M src/heap/heap.h
M src/heap/heap-inl.h
M src/ia32/lithium-codegen-ia32.cc
M src/lithium.h
M src/lithium.cc
M src/lithium-codegen.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/lithium-codegen-mips64.cc
M src/objects.h
M src/objects-inl.h
M src/x64/lithium-codegen-x64.cc
M src/x87/lithium-codegen-x87.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
