https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/scheduler-unittest.cc
File test/unittests/compiler/scheduler-unittest.cc (right):
https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/scheduler-unittest.cc#newcode35
test/unittests/compiler/scheduler-unittest.cc:35: static void
CheckRPONumbers(BasicBlockVector* order, size_t expected,
These static methods could be made into member methods on the test class
now. Also there seem to be two fundamental groups of tests (i.e. the
RPO-tests and the graph-based ones) and we could have two test classes
for that purpose, making that separation clear.
https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/scheduler-unittest.cc#newcode671
test/unittests/compiler/scheduler-unittest.cc:671: Handle<HeapObject>
object =
I am not an expert on how the unit-tests should be structured, but
should be have helper methods providing these objects? Maybe Benedikt
has an opinion.
https://codereview.chromium.org/863213003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
