LGTM with nits

Maybe the bug number should only be v8:3834 and then make v8:3330 depend on
v8:3834 instead.


https://codereview.chromium.org/803933008/diff/80001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):

https://codereview.chromium.org/803933008/diff/80001/src/x64/full-codegen-x64.cc#newcode3164
src/x64/full-codegen-x64.cc:3164: /* TODO[dslomov]: support pretenuring.
The style guide says to format these as: `TODO(dslomov):`

https://codereview.chromium.org/803933008/diff/80001/test/mjsunit/harmony/classes-experimental.js
File test/mjsunit/harmony/classes-experimental.js (right):

https://codereview.chromium.org/803933008/diff/80001/test/mjsunit/harmony/classes-experimental.js#newcode21
test/mjsunit/harmony/classes-experimental.js:21: } catch(e) {
} catch (e) {

space after `catch`, just like `if`, `else`, `for` etc.

https://codereview.chromium.org/803933008/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to