The large hex constants need to be given names. Eg kQuietNaNMask32 kQuietNaNMask64 and then assert that kQuietNaNMask32 << 1 has the high bit set.
You need an API test that inserts a noisy NaN and then does something with it. Otherwise LGTM http://codereview.chromium.org/339002 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
