https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/867153003/diff/1/src/runtime/runtime-classes.cc#newcode112
src/runtime/runtime-classes.cc:112: Handle<Code>
stub(isolate->builtins()->JSConstructStubForDerived());
On 2015/01/23 21:08:28, Dmitry Lomov (chromium) wrote:
On 2015/01/23 15:40:46, arv wrote:
> Let me make sure I understand this correctly. We replace the normal
construct
> stub with one that understands NewTarget.
Correct, although none of stubs yet understand new.target.
They both will eventually (soon).
JSConstructStubForDerived is the one that does not allocate and passes
a hole as
receiver.
>
> This makes me think I should use stubs for the default constructors
too.
Correct.
Yes, this patch does not cover default constructors. If you want I can
handle
stubs for them here (although I'd prefer a separate patch)
Lets handle it here in a different patch. I found some other work until
this one lands.
https://codereview.chromium.org/867153003/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/867153003/diff/40001/src/preparser.h#newcode2132
src/preparser.h:2132: kind = has_extends ?
FunctionKind::kSubclassConstructor
Sad. This needs to be dynamic since an extends value of null needs to be
treated as if no extends clause was present :'(
https://codereview.chromium.org/867153003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
