Nice patch. Just two drive-by-nits from me.
https://codereview.chromium.org/873143002/diff/1/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/873143002/diff/1/src/compiler/typer.cc#newcode919
src/compiler/typer.cc:919: if (rhs->Min() > 0 && rhs->Max() <= 31)
Nit: please add { and }.
https://codereview.chromium.org/873143002/diff/1/src/compiler/typer.cc#newcode926
src/compiler/typer.cc:926: if (rhs->Min() > 0 && rhs->Max() <= 31)
Nit: please add { and }.
https://codereview.chromium.org/873143002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
