http://codereview.chromium.org/335005/diff/1/2 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/335005/diff/1/2#newcode6541 Line 6541: __ mov(left_arg, left); On 2009/10/26 11:23:35, Kevin Millikin wrote: > I like the change with the symbolic names. Maybe this site deserves a comment > that the order of moves is important to avoid destroying right_arg/left? Done. Added comment in X64 version as well. http://codereview.chromium.org/335005/diff/1/2#newcode6549 Line 6549: __ mov(right_arg, right); On 2009/10/26 11:23:35, Kevin Millikin wrote: > Order of moves also important here. Done. Added comment in X64 version as well. http://codereview.chromium.org/335005/diff/1/2#newcode6555 Line 6555: __ mov(left_arg, left); On 2009/10/26 11:23:35, Kevin Millikin wrote: > Here, maybe a comment about what we know: neither left nor right is left_arg or > right_arg, and so the order of moves is not important. Done. Added comment in X64 version as well. http://codereview.chromium.org/335005/diff/1/2#newcode6614 Line 6614: bool is_commutative = (op_ == (Token::ADD) || (op_ == Token::MUL)); On 2009/10/26 11:23:35, Kevin Millikin wrote: > IsOperationCommutative()? Done. Fixed in x64 version as well. http://codereview.chromium.org/335005/diff/1/2#newcode6618 Line 6618: __ mov(right_arg, Immediate(left)); On 2009/10/26 11:23:35, Kevin Millikin wrote: > Do you want SetArgsReversed here? Thats right. This is a bug in the original version. I will try to find a test which exposes this. Fixed in x64 version as well. http://codereview.chromium.org/335005/diff/1/5 File src/x64/codegen-x64.h (right): http://codereview.chromium.org/335005/diff/1/5#newcode638 Line 638: // Flag that indicates whether how to generate code for the stub. On 2009/10/26 11:23:35, Kevin Millikin wrote: > Extra 'whether'. Done. Fixed in ia32 version as well. http://codereview.chromium.org/335005 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
