Looking good. Please update the CL description to match the new
implementation
(with two subclasses).
What's the state of duplicate property checking across engines? It's hard to
imagine actual code that depends on this behavior, but the number of test
changes involved does worry me a little bit about compatibility.
https://codereview.chromium.org/873823003/diff/80001/src/preparser.h
File src/preparser.h (left):
https://codereview.chromium.org/873823003/diff/80001/src/preparser.h#oldcode3056
src/preparser.h:3056:
parser()->ReportMessage("strict_duplicate_property");
If this message is now unused, you ought to be able to remove it (same
goes below).
https://codereview.chromium.org/873823003/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/873823003/diff/80001/src/preparser.h#newcode546
src/preparser.h:546: kMethodProperty = 3
Given that these are no longer bit patterns, you should be able to leave
off the values and let the compiler assign them.
https://codereview.chromium.org/873823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
