https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode13
src/compiler/move-optimizer.cc:13: struct MoveKey {
Once the issues mentioned below are addressed, how about getting rid of
this struct and using std::pair<InstructionOperand, InstructionOperand>
instead?
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode18
src/compiler/move-optimizer.cc:18: struct OperandLess {
Can you add an operator< (and operator>) to InstructionOperand instead?
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode34
src/compiler/move-optimizer.cc:34: typedef std::set<InstructionOperand,
std::less<InstructionOperand>,
I guess this shouldn't be std::less<InstructionOperand>, but rather
OperandLess?
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode36
src/compiler/move-optimizer.cc:36: typedef std::map<MoveKey, unsigned,
MoveKeyLess,
How about adding ZoneSet and ZoneMap to zone-containers.h and getting
rid of these typedefs, and replacing the classes below with simple
typedefs?
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode135
src/compiler/move-optimizer.cc:135: static bool
GapsCanMoveOver(Instruction* instr) {
Nit: use anonymous namespace instead of static.
https://codereview.chromium.org/755323011/diff/240001/src/compiler/move-optimizer.cc#newcode141
src/compiler/move-optimizer.cc:141: static int
FindFirstNonEmptySlot(GapInstruction* gap) {
Nit: use anonymous namespace instead of static.
https://codereview.chromium.org/755323011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
