Reviewers: vogelheim,
Description:
Only add API-triggered compilation to compile-script histogram.
[email protected]
Please review this at https://codereview.chromium.org/879273003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -2 lines):
M src/api.cc
M src/compiler.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
8ddd351f9e32067f14a6edffe5076f177a6924d9..9b6be9ac556bee65c45f635b9dcba90028d5c9e3
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -1598,6 +1598,7 @@ Local<UnboundScript> ScriptCompiler::CompileUnbound(
ENTER_V8(isolate);
i::SharedFunctionInfo* raw_result = NULL;
{ i::HandleScope scope(isolate);
+ i::HistogramTimerScope total(isolate->counters()->compile_script(),
true);
i::Handle<i::Object> name_obj;
int line_offset = 0;
int column_offset = 0;
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
4517b1f8704b19bab2ea2d492d75c5b26c8ace31..f7d3676e749abf8b3ac838f0994415095a1549ef
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1268,8 +1268,6 @@ Handle<SharedFunctionInfo> Compiler::CompileScript(
v8::Extension* extension, ScriptData** cached_data,
ScriptCompiler::CompileOptions compile_options, NativesFlag natives) {
Isolate* isolate = source->GetIsolate();
- HistogramTimerScope total(isolate->counters()->compile_script(), true);
-
if (compile_options == ScriptCompiler::kNoCompileOptions) {
cached_data = NULL;
} else if (compile_options == ScriptCompiler::kProduceParserCache ||
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
