LGTM, just nits. Sorry for delay, this somehow dropped off my radar.
https://codereview.chromium.org/886473005/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/886473005/diff/1/include/v8.h#newcode1533
include/v8.h:1533: * can be created without entering a v8::Context.
nit: Can we add "... and hence shouldn't escape to JavaScript" to the
comment just to drive home the point?
https://codereview.chromium.org/886473005/diff/1/include/v8.h#newcode1549
include/v8.h:1549: WeakMap(WeakMap&);
nit: // Disallow copying and assigning.
https://codereview.chromium.org/886473005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/886473005/diff/1/src/api.cc#newcode2242
src/api.cc:2242:
nit: // --- W e a k M a p ---
https://codereview.chromium.org/886473005/diff/1/src/runtime/runtime-collections.cc
File src/runtime/runtime-collections.cc (left):
https://codereview.chromium.org/886473005/diff/1/src/runtime/runtime-collections.cc#oldcode419
src/runtime/runtime-collections.cc:419: // strong root list.
Can we preserve an adapted version of this TODO within
Factory::NewJSWeakMap?
https://codereview.chromium.org/886473005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
