We could do this in one pass with a specialized Visitor.
+1, that seems much better.


https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc#newcode1754
src/heap/heap.cc:1754: }
Update new_array_buffer_views_list if the head was promoted?

https://codereview.chromium.org/904633003/diff/80001/src/heap/objects-visiting.cc
File src/heap/objects-visiting.cc (right):

https://codereview.chromium.org/904633003/diff/80001/src/heap/objects-visiting.cc#newcode237
src/heap/objects-visiting.cc:237: !heap->InNewSpace(original_candidate))
{
Let's DCHECK that the remaining objects are in old space.

https://codereview.chromium.org/904633003/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to