LGTM. Sigh ... :/

https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h
File src/bit-vector.h (right):

https://codereview.chromium.org/886733005/diff/1/src/bit-vector.h#newcode157
src/bit-vector.h:157: for (int i = 0; i < data_length_; i++) {
Just out of curiosity, is there a reason Clear doesn't use memset here?

https://codereview.chromium.org/886733005/diff/1/src/compiler/ast-loop-assignment-analyzer.cc
File src/compiler/ast-loop-assignment-analyzer.cc (right):

https://codereview.chromium.org/886733005/diff/1/src/compiler/ast-loop-assignment-analyzer.cc#newcode33
src/compiler/ast-loop-assignment-analyzer.cc:33: if (info()->is_osr() &&
info()->osr_ast_id() == loop->OsrEntryId())
Sigh ... :/

https://codereview.chromium.org/886733005/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to