Reviewers: adamk, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Fix usage of super in js perf test
BUG=none
LOG=N
[email protected], adamk
Please review this at https://codereview.chromium.org/916573002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+19, -22 lines):
M test/js-perf-test/Classes/super.js
Index: test/js-perf-test/Classes/super.js
diff --git a/test/js-perf-test/Classes/super.js
b/test/js-perf-test/Classes/super.js
index
a9ec7666884a8f9b683075885c7c7c170ccd38af..f282e9a5c88bfb215cbfe2031c7123065034d05b
100644
--- a/test/js-perf-test/Classes/super.js
+++ b/test/js-perf-test/Classes/super.js
@@ -10,39 +10,36 @@ var SuperBenchmark = new BenchmarkSuite('Super', [100],
[
]);
-function Base() { }
-Base.prototype = {
- constructor: Base,
+class Base {
+ constructor() {}
get x() {
return this._x++;
- },
+ }
set x(v) {
this._x += v;
return this._x;
}
+ f() {
+ return this._x++;
+ }
}
-Base.prototype.f = function() {
- return this._x++;
-}.toMethod(Base.prototype);
-function Derived() {
- this._x = 1;
+class Derived extends Base {
+ constructor() {
+ this._x = 1;
+ }
+ SuperCall() {
+ return super.f();
+ }
+ GetterCall() {
+ return super.x;
+ }
+ SetterCall() {
+ return super.x = 5;
+ }
}
-Derived.prototype = Object.create(Base.prototype);
-Object.setPrototypeOf(Derived, Base);
-
-Derived.prototype.SuperCall = function() {
- return super.f();
-}.toMethod(Derived.prototype);
-
-Derived.prototype.GetterCall = function() {
- return super.x;
-}.toMethod(Derived.prototype);
-Derived.prototype.SetterCall = function() {
- return super.x = 5;
-}.toMethod(Derived.prototype);
var derived = new Derived();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
