On 2009/11/10 16:09:07, Yury Semikhatsky wrote: > http://codereview.chromium.org/390001/diff/2001/3002 > File src/runtime.cc (right):
> http://codereview.chromium.org/390001/diff/2001/3002#newcode6026 > Line 6026: Object* e = old_names->get(i); > On 2009/11/10 16:04:08, Mads Ager wrote: > > Rename 'e' to 'name'? > Done. > http://codereview.chromium.org/390001/diff/2001/3001 > File test/cctest/test-debug.cc (right): > http://codereview.chromium.org/390001/diff/2001/3001#newcode3442 > Line 3442: // See http://crbug.com/26491 > On 2009/11/10 16:04:08, Mads Ager wrote: > > Could you add a one line description before the bug link? > Done. LGTM, As the hidden properties are used by the embedder I don't think we would ever want to expose the content of these in the JavaScript debugger, unless we add some 'expose internals' targeted as debugging of the bindings at the JavaScript level. http://codereview.chromium.org/390001 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
