Still in transit. Can you add tests for Array.is array and concat too?
On a higher level I think we should probably always pass original constructor but lets talk about that tomorrow. On Mar 2, 2015 3:43 PM, <dslo...@chromium.org> wrote: > Reviewers: *arv, *mvstanton, rossberg, > > Message: > PTAL before platform ports > > Description: > Implement subclassing Arrays. > > R=mvstan...@chromium.org,a...@chromium.org,rossb...@chromium.org > BUG=v8:3930 > LOG=Y > > Please review this at https://codereview.chromium.org/975463002/ > > Base URL: https://chromium.googlesource.com/v8/v8.git@master > > Affected files (+158, -34 lines): > M src/ia32/code-stubs-ia32.cc > M src/runtime/runtime.h > M src/runtime/runtime-array.cc > A test/mjsunit/harmony/classes-subclass-arrays.js > M test/mjsunit/harmony/regress/regress-3930.js > > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > ---You received this message because you are subscribed to the Google > Groups "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
