Reviewers: jochen (traveling),

Description:
When using ninja and clang, make sure diagnostics are colored.

BUG=none
LOG=N

Please review this at https://codereview.chromium.org/969653004/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+7, -0 lines):
  M build/standalone.gypi


Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index b74e80f08b1b6cadfb09f395fa0c02fbe305e4c5..e09952b1fff8be92bc6530506ba06675745f0e89 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -529,6 +529,13 @@
         ],  # target_conditions
       },  # target_defaults
     }],  # OS=="mac"
+    ['clang==1 and "<(GENERATOR)"=="ninja"', {
+      # See http://crbug.com/110262
+      'target_defaults': {
+        'cflags': [ '-fcolor-diagnostics' ],
+        'xcode_settings': { 'OTHER_CFLAGS': [ '-fcolor-diagnostics' ] },
+      },
+    }],
     ['clang==1 and ((OS!="mac" and OS!="ios") or clang_xcode==0) '
         'and OS!="win" and "<(GENERATOR)"=="make"', {
       'make_global_settings': [


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to