The style guide only applies to Chromium proper, not subrepos, but some of
the
toolchain constraints that apply to Chromium also apply to V8 (or at least
the
parts of V8 that need to build in chromium).
+thakis for OS X
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi#newcode527
build/standalone.gypi:527: 'CLANG_CXX_LIBRARY': 'libc++', #
-stdlib=libc++
We support OS X 10.6 which doesn't support C++11, IIUC
https://codereview.chromium.org/978783002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/978783002/diff/40001/include/v8.h#newcode854
include/v8.h:854: V8_INLINE UniquePersistent&
operator=(UniquePersistent<S>&& rhs) {
operator=(T&&)s should support self assignment, but this appears to blow
away the object if |*this| == |rhs|. a safer way to write this would be
if (this != &rhs) {
TYPE_CHECK
..
}
return *this
https://codereview.chromium.org/978783002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/978783002/diff/40001/test/cctest/test-api.cc#newcode3260
test/cctest/test-api.cc:3260: vector.push_back(std::move(global));
this won't compile on all platforms that chromium builds on. does this
build as part of chromium builds or only v8 builds?
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
