Whoops, I meant: stv!
http://codereview.chromium.org/394007/diff/5001/5015 File SConstruct (right): http://codereview.chromium.org/394007/diff/5001/5015#newcode130 Line 130: 'CCFLAGS': ['-O0', '-g', '-fomit-frame-pointer', '-fdata-sections', Ahem. http://codereview.chromium.org/394007/diff/5001/5013 File src/serialize.cc (right): http://codereview.chromium.org/394007/diff/5001/5013#newcode822 Line 822: CHECK(data == SYNCHRONIZE); Why is this not an ASSERT? Also CHECK_EQ? http://codereview.chromium.org/394007/diff/5001/5002 File test/cctest/test-serialize.cc (left): http://codereview.chromium.org/394007/diff/5001/5002#oldcode177 Line 177: #ifdef DEBUG We have corresponding tests for the new serializer right? http://codereview.chromium.org/394007 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
