Reviewers: jochen (traveling), Nico, Jakob,
Message:
PTAL. Has only an effect when in target_defaults...
Description:
Fix full rebuilding after clang rolls.
BUG=chromium:464657
LOG=n
Please review this at https://codereview.chromium.org/990253002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -8 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
1aedbcd595904e3c5a5cef1f1e5cc28a4ea23197..95ffb998d9d727b8fb3f0da5dbfd7659a13ff1d7
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -193,6 +193,16 @@
# Xcode insists on this empty entry.
},
},
+ 'conditions':[
+ ['(clang==1 or host_clang==1) and OS!="win"', {
+ # This is here so that all files get recompiled after a clang roll
and
+ # when turning clang on or off.
+ # (defines are passed via the command line, and build systems
rebuild
+ # things when their commandline changes). Nothing should ever read
this
+ # define.
+ 'defines':
['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh
--print-revision)'],
+ }],
+ ],
'target_conditions': [
['v8_code == 0', {
'defines!': [
@@ -558,14 +568,6 @@
['CC', '../<(clang_dir)/bin/clang-cl'],
],
}],
- ['(clang==1 or host_clang==1) and OS!="win"', {
- # This is here so that all files get recompiled after a clang roll
and
- # when turning clang on or off.
- # (defines are passed via the command line, and build systems rebuild
- # things when their commandline changes). Nothing should ever read
this
- # define.
- 'defines':
['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh
--print-revision)'],
- }],
# TODO(yyanagisawa): supports GENERATOR==make
# make generator doesn't support CC_wrapper without CC
# in make_global_settings yet.
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
